fix: priority always rejected + cleanup form validation #11
+89
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godarkrai
reviewed
Apr 19, 2024
iMarbot
changed the title
iMarbot
changed the title
@godarkrai I tested it and it all appears to work as desired. |
godarkrai
reviewed
Apr 22, 2024
iMarbot
commented
Apr 22, 2024
Co-authored-by: Shashank Atreya <[email protected]>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @hjpalpha on discord, the form data is rejected by the php because it is returned as string rather than as int/number type. This should check string for being all digits (int-like) and then convert to int before sending off to update db.
If there's a better way to fix this, feel free to change or close this PR.
Added a small change to i18n for submit buttons too.